fix: surface detailed GitHub auth errors#11248
Conversation
Render the server-provided GitHub authentication error message in cloud-mode auth surfaces instead of always falling back to a generic missing-auth copy. Co-Authored-By: Oz <oz-agent@warp.dev>
Constrain Cloud Mode GitHub auth and setup error messages so long server-provided copy stays within the pane/card layout without changing the displayed text. Co-Authored-By: Oz <oz-agent@warp.dev>
captainsafia
force-pushed
the
oz-agent/github-auth-error-messages
branch
from
8d471e5 to
4ad168a
Compare
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the Cloud Mode setup status bar to show the server-provided GitHub authentication failure message, while preserving the GitHub authentication link and adding wrapping support for longer messages. It also updates the existing auth URL unit test to assert the auth error message is available.
Concerns
No blocking correctness, security, or spec-alignment concerns were identified in the annotated diff. The PR includes visual evidence for the user-facing status-bar behavior.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
2 participants
Description
Render the server-provided GitHub auth failure message in cloud-mode GitHub auth surfaces instead of always showing the generic “Missing GitHub authentication.” copy.
This lets the app show more specific failures such as a connected GitHub account missing access to repos defined by the selected environment.
Linked Issue
ready-to-specorready-to-implement.Slack thread: D0AU96L8CDV / 1779148608.734439
Testing
cargo test --manifest-path /workspace/warp/Cargo.toml -p warp github_auth_url_for_initial_run_includes_focus_cloud_mode_next./script/runScreenshots / Videos
https://www.loom.com/share/cc5d44ebc4284911aa2d9f2a641ec86b
Agent Mode
Conversation: https://staging.warp.dev/conversation/e3ac34bc-4985-48fc-bd92-970fd4be91aa
Run: https://oz.staging.warp.dev/runs/019e3d85-5d38-72b4-b0ed-18430632414f
This PR was generated with Oz.